-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix: account filter param diff #9701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: account filter param diff #9701
Conversation
AdriiiPRodri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this happens in more endpoints, so we will need to add the ProviderIdAdaptaerMixin in others filters no?
You're right, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alejandrobailo Looks good, but we are missing unit test cases, regenerating the API spec and the changelog entry. Also:
vicferpoy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alejandrobailo API PR checks are still pending. Please mark them as complete if they are.
Context
Unify provider filter parameter naming between frontend and API. The findings endpoint now accepts both provider and provider_id parameters, allowing the frontend to use provider_id__in consistently across all pages without translation.
Description
Steps to review
- risk-plot-client.tsx:48
- finding-severity-over-time.tsx:69
- sankey-chart.tsx (removed mapProviderFiltersForFindings calls)
Checklist
UI
API
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.